From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] hptiop: adding new firmware interface and more PCI device IDs Date: Wed, 29 Aug 2007 06:39:50 -0400 Message-ID: <46D54CF6.7060009@garzik.org> References: <200605101704.27491.linux@highpoint-tech.com> <200605121107.48597.linux@highpoint-tech.com> <200605161438.09717.linux@highpoint-tech.com> <200708291510.53793.linux@highpoint-tech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:38167 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251AbXH2Kj5 (ORCPT ); Wed, 29 Aug 2007 06:39:57 -0400 In-Reply-To: <200708291510.53793.linux@highpoint-tech.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: HighPoint Linux Team Cc: Andrew Morton , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, James.Bottomley@SteelEye.com HighPoint Linux Team wrote: > + if (hba->firmware_version > 0x01020000 || hba->interface_version > 0x01020000) { [...] > + if (hba->firmware_version > 0x01020000 || > + hba->interface_version > 0x01020000) { Rather than repeating this test, you should do it once at probe time, and set a "new interface" single-bit flag in some hptiop_hba field. Less maintenance intensive, less prone to error, and removes expensive tests from the driver hotpath. > static struct pci_device_id hptiop_id_table[] = { > - { PCI_DEVICE(0x1103, 0x3220) }, > - { PCI_DEVICE(0x1103, 0x3320) }, > + { PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x3220) }, > + { PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x3320) }, > + { PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x3520) }, > + { PCI_DEVICE(PCI_VENDOR_ID_TTI, 0x4320) }, > {}, Using the PCI_VDEVICE() macro can make this even shorter: { PCI_VDEVICE(TTI, 0x4320) } Regards, Jeff