All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Roland Dreier <rdreier@cisco.com>, Divy Le Ray <divy@chelsio.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Steve Wise <swise@opengridcomputing.com>
Subject: Re: [PATCH 2.6.23 0/2] cxgb3 - Fix dev->priv usage
Date: Wed, 29 Aug 2007 06:42:27 -0400	[thread overview]
Message-ID: <46D54D93.5020100@garzik.org> (raw)
In-Reply-To: <ada3ay26gys.fsf@cisco.com>

Roland Dreier wrote:
> Looks OK to me but I would just roll up the second patch into the
> first patch and let Jeff merge it as one commit.  There's no point in
> creating an intermediate tree that doesn't build -- it just breaks git
> bisect for no useful purpose.

Agreed -- this needs to be in a single patch.

	Jeff




  reply	other threads:[~2007-08-29 10:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-29  4:08 [PATCH 2.6.23 0/2] cxgb3 - Fix dev->priv usage Divy Le Ray
2007-08-29  5:35 ` Roland Dreier
2007-08-29 10:42   ` Jeff Garzik [this message]
2007-08-29 17:53   ` Divy Le Ray
2007-09-04 15:09     ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46D54D93.5020100@garzik.org \
    --to=jeff@garzik.org \
    --cc=divy@chelsio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdreier@cisco.com \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.