All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Guthro <bguthro@virtualiron.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH 2/3] Fix Spinlock compile errors
Date: Wed, 29 Aug 2007 14:14:42 -0400	[thread overview]
Message-ID: <46D5B792.4000805@virtualiron.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

Remove extra parentheses in netif_tx_lock_bh and etif_tx_unlock_bh 
macros, as it caused problems
when compiling against a SLES9 tree.

While at first glance - the existing code should work, these extraneous 
parentheses were causing build errors.
It seems to me this was either a buggy kernel, or a buggy compiler, for 
this to fail.

However, this change, (though subtle) does fix the compile error, and 
does not cause any other problems in newer guest kernels.

Signed-off-by: Ben Guthro <bguthro@virtualiron.com>

[-- Attachment #2: xen-legacy-spinlock.patch --]
[-- Type: text/x-patch, Size: 778 bytes --]

diff -r e9f35dc18ae9 unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h
--- a/unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h	Wed Aug 15 16:15:06 2007 -0400
+++ b/unmodified_drivers/linux-2.6/compat-include/xen/platform-compat.h	Wed Aug 15 16:15:28 2007 -0400
@@ -108,8 +108,8 @@ extern char *kasprintf(gfp_t gfp, const 
 #endif
 
 #if defined(_LINUX_NETDEVICE_H) && LINUX_VERSION_CODE < KERNEL_VERSION(2,6,18)
-#define netif_tx_lock_bh(dev) (spin_lock_bh(&(dev)->xmit_lock))
-#define netif_tx_unlock_bh(dev) (spin_unlock_bh(&(dev)->xmit_lock))
+#define netif_tx_lock_bh(dev) spin_lock_bh(&(dev)->xmit_lock)
+#define netif_tx_unlock_bh(dev) spin_unlock_bh(&(dev)->xmit_lock)
 #endif
 
 #if defined(__LINUX_SEQLOCK_H) && !defined(DEFINE_SEQLOCK)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

                 reply	other threads:[~2007-08-29 18:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46D5B792.4000805@virtualiron.com \
    --to=bguthro@virtualiron.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.