From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: Re: [-mm PATCH] Memory controller improve user interface Date: Thu, 30 Aug 2007 14:43:15 +0530 Message-ID: <46D68A2B.7040106@linux.vnet.ibm.com> References: <20070829111030.9987.8104.sendpatchset@balbir-laptop> <1188413148.28903.113.camel@localhost> <46D5ED5C.9030405@linux.vnet.ibm.com> <1188425894.28903.140.camel@localhost> <6599ad830708291520t2bc9ea20m2bdcd9e042b3a423@mail.gmail.com> <1188426352.28903.143.camel@localhost> <46D5F517.1080809@linux.vnet.ibm.com> <20070830143859.e9d3511a.kamezawa.hiroyu@jp.fujitsu.com> Reply-To: balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070830143859.e9d3511a.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: KAMEZAWA Hiroyuki Cc: Linux Kernel Mailing List , Linux MM Mailing List , David Rientjes , Linux Containers , Paul Menage , Andrew Morton List-Id: containers.vger.kernel.org KAMEZAWA Hiroyuki wrote: > On Thu, 30 Aug 2007 04:07:11 +0530 > Balbir Singh wrote: >> 1. Several people recommended it >> 2. Herbert mentioned that they've moved to that interface and it >> was working fine for them. >> > > I have no strong opinion. But how about Mega bytes ? (too big ?) > There will be no rounding up/down problem. > Here is what I am thinking, allow the user to input bytes/kilobytes/ megabytes or gigabytes. Store the data internally in kilobytes or PFN. I prefer kilobytes (no rounding issues), but while implementing limits we round up to the closest PFN. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759585AbXH3JPg (ORCPT ); Thu, 30 Aug 2007 05:15:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759365AbXH3JPX (ORCPT ); Thu, 30 Aug 2007 05:15:23 -0400 Received: from E23SMTP02.au.ibm.com ([202.81.18.163]:44033 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750958AbXH3JPV (ORCPT ); Thu, 30 Aug 2007 05:15:21 -0400 Message-ID: <46D68A2B.7040106@linux.vnet.ibm.com> Date: Thu, 30 Aug 2007 14:43:15 +0530 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com Organization: IBM User-Agent: Thunderbird 1.5.0.12 (X11/20070604) MIME-Version: 1.0 To: KAMEZAWA Hiroyuki CC: Dave Hansen , Linux Kernel Mailing List , Linux MM Mailing List , David Rientjes , Linux Containers , Paul Menage , Andrew Morton Subject: Re: [-mm PATCH] Memory controller improve user interface References: <20070829111030.9987.8104.sendpatchset@balbir-laptop> <1188413148.28903.113.camel@localhost> <46D5ED5C.9030405@linux.vnet.ibm.com> <1188425894.28903.140.camel@localhost> <6599ad830708291520t2bc9ea20m2bdcd9e042b3a423@mail.gmail.com> <1188426352.28903.143.camel@localhost> <46D5F517.1080809@linux.vnet.ibm.com> <20070830143859.e9d3511a.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20070830143859.e9d3511a.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org KAMEZAWA Hiroyuki wrote: > On Thu, 30 Aug 2007 04:07:11 +0530 > Balbir Singh wrote: >> 1. Several people recommended it >> 2. Herbert mentioned that they've moved to that interface and it >> was working fine for them. >> > > I have no strong opinion. But how about Mega bytes ? (too big ?) > There will be no rounding up/down problem. > Here is what I am thinking, allow the user to input bytes/kilobytes/ megabytes or gigabytes. Store the data internally in kilobytes or PFN. I prefer kilobytes (no rounding issues), but while implementing limits we round up to the closest PFN. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sd0109e.au.ibm.com (d23rh905.au.ibm.com [202.81.18.225]) by e23smtp05.au.ibm.com (8.13.1/8.13.1) with ESMTP id l7U9DTlH013837 for ; Thu, 30 Aug 2007 19:13:29 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.250.244]) by sd0109e.au.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l7U9H08r190026 for ; Thu, 30 Aug 2007 19:17:00 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l7U9DQd3011258 for ; Thu, 30 Aug 2007 19:13:26 +1000 Message-ID: <46D68A2B.7040106@linux.vnet.ibm.com> Date: Thu, 30 Aug 2007 14:43:15 +0530 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com MIME-Version: 1.0 Subject: Re: [-mm PATCH] Memory controller improve user interface References: <20070829111030.9987.8104.sendpatchset@balbir-laptop> <1188413148.28903.113.camel@localhost> <46D5ED5C.9030405@linux.vnet.ibm.com> <1188425894.28903.140.camel@localhost> <6599ad830708291520t2bc9ea20m2bdcd9e042b3a423@mail.gmail.com> <1188426352.28903.143.camel@localhost> <46D5F517.1080809@linux.vnet.ibm.com> <20070830143859.e9d3511a.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20070830143859.e9d3511a.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: Dave Hansen , Linux Kernel Mailing List , Linux MM Mailing List , David Rientjes , Linux Containers , Paul Menage , Andrew Morton List-ID: KAMEZAWA Hiroyuki wrote: > On Thu, 30 Aug 2007 04:07:11 +0530 > Balbir Singh wrote: >> 1. Several people recommended it >> 2. Herbert mentioned that they've moved to that interface and it >> was working fine for them. >> > > I have no strong opinion. But how about Mega bytes ? (too big ?) > There will be no rounding up/down problem. > Here is what I am thinking, allow the user to input bytes/kilobytes/ megabytes or gigabytes. Store the data internally in kilobytes or PFN. I prefer kilobytes (no rounding issues), but while implementing limits we round up to the closest PFN. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org