From: Francesco Dolcini <fdolcini@sysnetsistemi.it>
To: netdev@vger.kernel.org
Subject: bonding xmit overwrite skb->priority
Date: Thu, 30 Aug 2007 12:06:20 +0200 [thread overview]
Message-ID: <46D6969C.5080005@sysnetsistemi.it> (raw)
Bonding code set skb->priority=1 before trasmitting frame to the slave
device (bond_dev_queue_xmit() in bond_main.c). The only reason I can
think of doing this is to be sure that control packet used by bonding
specific implementation (802.3ad PDU for example) using priority
TC_PRIO_CONTROL will never get delayed by other traffic (using the
default qdisc pfifo_fast). The problem doing this is that priority
information in skb get lost.
I removed this line because I need to trust skb priority in the slave
device qdisc and I got no negative effects, am I missing something?
There are other reason for setting skb->priority to 1?
thanks
Francesco
reply other threads:[~2007-08-30 10:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D6969C.5080005@sysnetsistemi.it \
--to=fdolcini@sysnetsistemi.it \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.