From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [PATCH] 1/2: cpufreq/PowerNow! in Xen: Time and platform changes Date: Thu, 30 Aug 2007 10:59:11 -0400 Message-ID: <46D6DB3F.3080104@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "Tian, Kevin" , xen-devel@lists.xensource.com, Mark Langsdorf List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > Personally I'm a fan of doing it in dom0 userspace, although doing it within > Xen can also be argued for. Doing it in dom0 kernel doesn't seem very > attractive apart from the obvious pragmatic advantage that all the code is > already in the Linux kernel. :-) Code duplication is bad. It is the reason why Xen will (hopefully) go away in the long run. Please do not propagate this horrible idea that all code should be copied around and have obsolete versions maintained forever. The dom0 kernel is where the code already lives, so that code should be used. -- Politics is the struggle between those who want to make their country the best in the world, and those who believe it already is. Each group calls the other unpatriotic.