All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Daniel Ritz <daniel.ritz-ml@swissonline.ch>,
	Luca Tettamanti <kronos.it@gmail.com>,
	linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] ACPI: EC: Check if boot_ec was really found in DSDT
Date: Fri, 31 Aug 2007 09:05:26 +0400	[thread overview]
Message-ID: <46D7A196.7070309@suse.de> (raw)
In-Reply-To: <alpine.LFD.0.999.0708301020410.25853@woody.linux-foundation.org>

From: Alexey Starikovskiy <astarikovskiy@suse.de>

acpi_get_devices() returns success if it did not find any device.
We have to check for this case.

Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
---

 drivers/acpi/ec.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 43749c8..3f7935a 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -886,7 +886,8 @@ int __init acpi_ec_ecdt_probe(void)
         printk(KERN_DEBUG PREFIX "Look up EC in DSDT\n");
         status = acpi_get_devices(ec_device_ids[0].id, ec_parse_device,
                         boot_ec, NULL);
-        if (ACPI_FAILURE(status))
+        /* Check that acpi_get_devices actually find something */
+        if (ACPI_FAILURE(status) || !boot_ec->handle)
             goto error;
     }
 


  parent reply	other threads:[~2007-08-31  5:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-28 23:29 Linux 2.6.23-rc4: BAD regression Daniel Ritz
2007-08-28 23:42 ` Linus Torvalds
2007-08-29  4:41 ` Alexey Starikovskiy
2007-08-29 19:35   ` Daniel Ritz
2007-08-29 19:45     ` Alexey Starikovskiy
2007-08-29 20:55       ` Daniel Ritz
2007-08-29 23:21 ` Luca Tettamanti
2007-08-30 17:07   ` Daniel Ritz
2007-08-30 17:21     ` Linus Torvalds
2007-08-30 19:17       ` Luca
2007-08-31  5:05       ` Alexey Starikovskiy [this message]
2007-08-31  5:22         ` [PATCH] ACPI: EC: Check if boot_ec was really found in DSDT Linus Torvalds
2007-08-31  5:29           ` Alexey Starikovskiy
2007-08-31  5:34             ` Andrew Morton
2007-08-31  5:47               ` mail client to send patches Alexey Starikovskiy
2007-08-31  7:07               ` [PATCH] ACPI: EC: Check if boot_ec was really found in DSDT Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46D7A196.7070309@suse.de \
    --to=astarikovskiy@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=daniel.ritz-ml@swissonline.ch \
    --cc=kronos.it@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.