From: Marius Storm-Olsen <marius@trolltech.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git mailing list <git@vger.kernel.org>,
Stephen Cuppett <cuppett@gmail.com>,
Nanako Shiraishi <nanako3@bluebottle.com>
Subject: Re: [PATCH] autodetect core.symlinks in git-init
Date: Fri, 31 Aug 2007 10:23:01 +0200 [thread overview]
Message-ID: <46D7CFE5.9040508@trolltech.com> (raw)
In-Reply-To: <7vodgo2moe.fsf_-_@gitster.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 579 bytes --]
Junio C Hamano said the following on 31.08.2007 09:22:
> We already autodetect if filemode is reliable on the filesystem
> to deal with VFAT and friends. Do the same for symbolic link
> support.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> + if (!close(xmkstemp(path)) &&
Just tried this with 4msysgit (so, MinGW on Windows), and with a patch
for adding xmkstemp() to git-compat-util.h, this patch works perfectly
on Windows. It's obviously the right thing to do.
Acked-by: Marius Storm-Olsen <mstormo_git@storm-olsen.com>
--
.marius
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 187 bytes --]
next prev parent reply other threads:[~2007-08-31 8:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 1:35 [RFC] Change handling of RelNotes Stephen Cuppett
2007-08-31 1:39 ` Petr Baudis
2007-08-31 6:04 ` Junio C Hamano
2007-08-31 2:21 ` Junio C Hamano
2007-08-31 6:08 ` Marius Storm-Olsen
2007-08-31 6:44 ` Nanako Shiraishi
2007-08-31 7:09 ` Junio C Hamano
2007-08-31 7:22 ` [PATCH] autodetect core.symlinks in git-init Junio C Hamano
2007-08-31 8:00 ` Nanako Shiraishi
2007-08-31 8:23 ` Marius Storm-Olsen [this message]
[not found] ` <316a20a40708310539w1d20c391w8566a042c7a8679a@mail.gmail.com>
2007-08-31 12:52 ` [RFC] Change handling of RelNotes Stephen Cuppett
2007-08-31 20:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D7CFE5.9040508@trolltech.com \
--to=marius@trolltech.com \
--cc=cuppett@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nanako3@bluebottle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.