Re: [RFC][PATCH] uli526x: Add suspend and resume routines (updated)

[Jeff Garzik <jeff@garzik.org>]

Rafael J. Wysocki wrote:
> On Tuesday, 14 August 2007 07:58, Jeff Garzik wrote:
>> Rafael J. Wysocki wrote:
>>> On Wednesday, 8 August 2007 00:26, Jeff Garzik wrote:
>>>> Rafael J. Wysocki wrote:
>>>>> On Tuesday, 7 August 2007 23:40, Jeff Garzik wrote:
>>>>>> I'll let our new tulip maintainer see what he thinks about the 
>>>>>> implementation.  Seems fairly sane to me, but should at least get an "it 
>>>>>> works" test.
>>>>> It has been tested, as stated in the changelog, and works (on my test system).
> [--snip--]
>  
>> Two comments:
>>
>> 1) Like akpm, the CONFIG_PM_SLEEP is out of place.  All other drivers 
>> use CONFIG_PM
> 
> OK
> 
>> 2) just remove the !dev checks, that is an impossible condition
> 
> OK
> 
> Updated patch follows.
> 
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
> 
> Add suspend/resume support to the uli526x network driver (tested on x86_64,
> with 'Ethernet controller: ALi Corporation M5263 Ethernet Controller, rev 40').
> 
> This patch is based on the suspend/resume code in the tg3 driver.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
>  drivers/net/tulip/uli526x.c |  108 +++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 102 insertions(+), 6 deletions(-)

applied