Talpey, Thomas wrote: > At 12:27 PM 8/31/2007, Chuck Lever wrote: >> Talpey, Thomas wrote: >>> "RPCB_" prefix: They're (with this patch) part of the rpcbind api. The prefix >> ... >> It's a nit, I guess. > > How about RPCBIND_NETID_foo? It's more obvious, and keeps the RPC... OK by me. >>> RPCB_MAXNETIDLEN: Sure, I'll move it. It is, after all, a limit on the string >>> ... >> We need to know the maximum size to compute the largest possible size of >> the RPC buffer needed for the request. See the definition of >> RPCB_netid_sz. Those are all added together to get the largest possible >> request size, and that's used to compute the largest possible buffer size. > > Yes, I know, but it could be larger and more dynamically calculated. I'm not sure what you mean, then. The buffer size maximums are statically computed at kernel compile time.