From: Patrick McHardy <kaber@trash.net>
To: jdb@comx.dk
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2]: [NET_SCHED]: Make all rate based scheduler work with TSO.
Date: Sat, 01 Sep 2007 09:09:47 +0200 [thread overview]
Message-ID: <46D9103B.7090905@trash.net> (raw)
In-Reply-To: <1188562975.18622.11.camel@localhost.localdomain>
Jesper Dangaard Brouer wrote:
> commit 6fdc0f061be94f5e297650961360fb7a9d1cc85d
> Author: Jesper Dangaard Brouer <hawk@comx.dk>
> Date: Thu Aug 30 17:53:42 2007 +0200
>
> [NET_SCHED]: Make all rate based scheduler work with TSO.
>
> Change L2T (length to time) macros, in all rate based schedulers, to
> call a common function qdisc_l2t() that does the rate table lookup.
> This function handles if the packet size lookup is larger than the
> rate table, which often occurs with TSO enabled.
It still won't work properly with TSO (TBF for example already drops
oversized packets during ->enqueue), but its a good cleanup anyway.
> +#define L2T(p,L) ((p)->tcfp_R_tab, L)
> +#define L2T_P(p,L) ((p)->tcfp_P_tab, L)
I'd prefer to get rid of these L2T macros completely.
next prev parent reply other threads:[~2007-09-01 7:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 12:22 [PATCH 1/2]: [NET_SCHED]: Make all rate based scheduler work with TSO Jesper Dangaard Brouer
2007-09-01 7:09 ` Patrick McHardy [this message]
2007-09-01 21:38 ` Jesper Dangaard Brouer
2007-09-04 3:34 ` Bill Fink
2007-09-04 16:23 ` Patrick McHardy
2007-09-04 17:40 ` Bill Fink
2007-09-05 9:17 ` Jesper Dangaard Brouer
2007-09-06 3:59 ` Bill Fink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D9103B.7090905@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jdb@comx.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.