From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, Auke Kok <auke-jan.h.kok@intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 1/10] ide: use pci_dev->revision
Date: Sat, 01 Sep 2007 20:21:30 +0400 [thread overview]
Message-ID: <46D9918A.6000703@ru.mvista.com> (raw)
In-Reply-To: <200708292316.38779.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> Some places were using PCI_CLASS_REVISION instead of PCI_REVISION_ID so
> they were not converted by commit 44c10138fd4bbc4b6d6bff0873c24902f2a9da65.
> ---
> Quick grep over kernel tree finds out many other places using either
> pci_read_config_dword(dev, PCI_CLASS_REVISION, ...) & 0xff or simply
> pci_read_config_byte(dev, PCI_CLASS_REVISION, ...) and they all can be
> converted to using dev->revision.
Nice! I was wondering all the time why the revision ID isn't held with he
device/vendor IDs (wile being a vital detail for many IDE chips ;-).
> Auke, a "PCI_CLASS_REVISION" follow-up to your previous patch would be great.
> :)
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2007-09-01 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-29 21:16 [PATCH 1/10] ide: use pci_dev->revision Bartlomiej Zolnierkiewicz
2007-08-29 21:39 ` Kok, Auke
2007-08-29 22:09 ` Bartlomiej Zolnierkiewicz
2011-02-16 17:52 ` Sergei Shtylyov
2011-02-16 19:26 ` Auke Kok
2007-09-01 16:21 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D9918A.6000703@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=auke-jan.h.kok@intel.com \
--cc=bzolnier@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.