From: Jeff Garzik <jeff@garzik.org>
To: Andi Kleen <ak@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] x86/x86-64 PCI domain support
Date: Sat, 01 Sep 2007 18:06:12 -0400 [thread overview]
Message-ID: <46D9E254.6010702@garzik.org> (raw)
In-Reply-To: <200709020000.03375.ak@suse.de>
Andi Kleen wrote:
>>
>> +config PCI_DOMAINS
>> + bool "PCI domain support"
>> + depends on PCI
>
> I don't think this should be a config option.
CONFIG_PCI_DOMAINS is referenced in arch-neutral code, so the symbol
_must_ be defined.
It can be hidden, perhaps, if that makes our x86 maintainer happy :)
> But there should be a pci=... option with Documentation to turn it off at runtime
OK
>> +static inline int pci_proc_domain(struct pci_bus *bus)
>> +{
>> + return pci_domain_nr(bus);
>> +}
>
> The second function is redundant?
No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled.
Jeff
next prev parent reply other threads:[~2007-09-01 22:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-01 14:32 [PATCH] x86/x86-64 PCI domain support Jeff Garzik
2007-09-01 22:00 ` Andi Kleen
2007-09-01 22:06 ` Jeff Garzik [this message]
2007-09-01 22:26 ` Andi Kleen
2007-09-01 22:40 ` Jeff Garzik
2007-09-02 16:46 ` Randy Dunlap
2007-09-02 16:56 ` Jeff Garzik
2007-09-02 17:15 ` Randy Dunlap
2007-09-02 9:19 ` Muli Ben-Yehuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D9E254.6010702@garzik.org \
--to=jeff@garzik.org \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.