From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rene Herman Subject: Re: [PATCH -mm] sb16: Shut up uninitialized var build warning Date: Mon, 03 Sep 2007 00:06:08 +0200 Message-ID: <46DB33D0.40204@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtpq1.groni1.gr.home.nl (smtpq1.groni1.gr.home.nl [213.51.130.200]) by alsa0.perex.cz (Postfix) with ESMTP id 14395243AD for ; Mon, 3 Sep 2007 00:12:25 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Satyam Sharma Cc: Takashi Iwai , alsa-devel@alsa-project.org, Linux Kernel Mailing List , Jaroslav Kysela List-Id: alsa-devel@alsa-project.org T24gMDkvMDIvMjAwNyAxMDoxNSBQTSwgU2F0eWFtIFNoYXJtYSB3cm90ZToKCj4gc291bmQvaXNh L3NiMTYvc2IxNi5jOiBJbiBmdW5jdGlvbiDigJhzbmRfc2IxNl9pc2FfcHJvYmXigJk6CgpCbGFo LiBZb3VyIG1lc3NhZ2UgaGFzOgoKCUNvbnRlbnQtVHlwZTogVEVYVC9QTEFJTjsgY2hhcnNldD1p c28tMjAyMi1qcAoKVGhpcyBhcHBhcmVudGx5IGlzIGNhdXNlZCBieSBhIGNvbWJpbmF0aW9uIG9m IEdDQyB1c2luZyBncm9vdnkgVVRGIHRpY2ttYXJrcyAKaW4gaXRzIGVycm9yIG1lc3NhZ2VzIHdo ZW4gaW4gYSBVVEYgbG9jYWxlIGFuZCBhbHBpbmUgYmVsaWV2aW5nIGl0IHRvIGJlIGEgCmdyZWF0 IGlkZWEgdG8gYXV0b21hdGljYWxseSB0cnkgZm9yIHRoZSAic2ltcGxlc3QiIGNoYXJhY3RlciBz ZXQgaXQgY2FuIAplbmNvZGUgdGhlIGNvbnRlbnQgaW4uIE5vIGlkZWEgd2h5IHRoYXQgbWVhbnMg dGhhdCBpc28tMjAyMi1qcCBpcyBwaWNrZWQsIApidXQgaXQgaXMuCgpXaGlsZSBJIGNvdWxkIGFj dHVhbGx5IHJlYWQgdGhlIG1lc3NhZ2UgdGhpcyB0aW1lIHlvdSBzaG91bGQgc2VlIHdoYXQgCmlz by0yMDIyLWpwIGRvZXMgdG8gbXkgZm9udC4gSXQncyBzY2FyeS4gQmVzdCBzb2x1dGlvbiBhcyBm YXIgYXMgSSdtIApjb25jZXJuZWQgaXMgc2xhcCBhIGZldyBHQ0MgZGV2ZWxvcGVycyAobm90IHRo YXQgaXQgd2lsIGhlbHAsIGJ1dCBpdCdsbCAKY2VydGFpbmx5IGZlZWwgZ29vZCkgYW5kIHRoZW4g dGVhY2ggYWxwaW5lIHRvIGdvIGZvciBVVEYtOCBkaXJlY3RseSBpZiAKVVMtQVNDSUkgd29uJ3Qg ZG8uCgpBcyB0byB0aGUgY29udGVudCBvZiB0aGlzIHBhdGNoIC0tIEknZCBhbG1vc3Qgc2F5IGl0 J3MgYmV0dGVyIHRvIGxpdmUgd2l0aCAKdGhlIHdhcm5pbmcgdGhhbiB3aXRoIHRoYXQgdW5pdGlh bGl6ZWRfdmFyKCkgdGhpbmcuIFRoYXQgQVJSQVlfU0laRSBpcyB2ZXJ5IAptdWNoIGEgY29tcGls ZSB0aW1lIGNvbnN0YW50LCBzbyBleGFjdGx5IGhvdyBkdW1iIG11c3QgR0NDIGdldCBiZWZvcmUg d2UgZ2V0IAp0byBzYXkgdG8gaGVyZSBhbmQgbm8gZnVydGhlcj8KCj4gLS0tIGxpbnV4LTIuNi4y My1yYzQtbW0xL3NvdW5kL2lzYS9zYi9zYjE2LmN+Zml4CTIwMDctMDktMDIgMjE6NDE6NTEuMDAw MDAwMDAwICswNTMwCj4gKysrIGxpbnV4LTIuNi4yMy1yYzQtbW0xL3NvdW5kL2lzYS9zYi9zYjE2 LmMJMjAwNy0wOS0wMiAyMTo0Mjo1Ni4wMDAwMDAwMDAgKzA1MzAKPiBAQCAtNTU2LDcgKzU1Niw2 IEBAIHN0YXRpYyBpbnQgX19kZXZpbml0IHNuZF9zYjE2X2lzYV9tYXRjaCgKPiAgCj4gIHN0YXRp YyBpbnQgX19kZXZpbml0IHNuZF9zYjE2X2lzYV9wcm9iZShzdHJ1Y3QgZGV2aWNlICpwZGV2LCB1 bnNpZ25lZCBpbnQgZGV2KQo+ICB7Cj4gLQlpbnQgZXJyOwo+ICAJc3RhdGljIGludCBwb3NzaWJs ZV9pcnFzW10gPSB7NSwgOSwgMTAsIDcsIC0xfTsKPiAgCXN0YXRpYyBpbnQgcG9zc2libGVfZG1h czhbXSA9IHsxLCAzLCAwLCAtMX07Cj4gIAlzdGF0aWMgaW50IHBvc3NpYmxlX2RtYXMxNltdID0g ezUsIDYsIDcsIC0xfTsKPiBAQCAtNTg1LDYgKzU4NCw4IEBAIHN0YXRpYyBpbnQgX19kZXZpbml0 IHNuZF9zYjE2X2lzYV9wcm9iZSgKPiAgCWVsc2Ugewo+ICAJCXN0YXRpYyBpbnQgcG9zc2libGVf cG9ydHNbXSA9IHsweDIyMCwgMHgyNDAsIDB4MjYwLCAweDI4MH07Cj4gIAkJaW50IGk7Cj4gKwkJ aW50IHVuaW5pdGlhbGl6ZWRfdmFyKGVycik7Cj4gKwo+ICAJCWZvciAoaSA9IDA7IGkgPCBBUlJB WV9TSVpFKHBvc3NpYmxlX3BvcnRzKTsgaSsrKSB7Cj4gIAkJCXBvcnRbZGV2XSA9IHBvc3NpYmxl X3BvcnRzW2ldOwo+ICAJCQllcnIgPSBzbmRfc2IxNl9pc2FfcHJvYmUxKGRldiwgcGRldik7CgpS ZW5lLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWxz YS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3JnCmh0dHA6Ly9t YWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932948AbXIBWMb (ORCPT ); Sun, 2 Sep 2007 18:12:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754000AbXIBWMY (ORCPT ); Sun, 2 Sep 2007 18:12:24 -0400 Received: from smtpq1.groni1.gr.home.nl ([213.51.130.200]:48563 "EHLO smtpq1.groni1.gr.home.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753931AbXIBWMX (ORCPT ); Sun, 2 Sep 2007 18:12:23 -0400 Message-ID: <46DB33D0.40204@gmail.com> Date: Mon, 03 Sep 2007 00:06:08 +0200 From: Rene Herman User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: Satyam Sharma CC: Linux Kernel Mailing List , Takashi Iwai , Jaroslav Kysela , alsa-devel@alsa-project.org Subject: Re: [PATCH -mm] sb16: Shut up uninitialized var build warning References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-AtHome-MailScanner-Information: Please contact support@home.nl for more information X-AtHome-MailScanner: Found to be clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2007 10:15 PM, Satyam Sharma wrote: > sound/isa/sb16/sb16.c: In function ‘snd_sb16_isa_probe’: Blah. Your message has: Content-Type: TEXT/PLAIN; charset=iso-2022-jp This apparently is caused by a combination of GCC using groovy UTF tickmarks in its error messages when in a UTF locale and alpine believing it to be a great idea to automatically try for the "simplest" character set it can encode the content in. No idea why that means that iso-2022-jp is picked, but it is. While I could actually read the message this time you should see what iso-2022-jp does to my font. It's scary. Best solution as far as I'm concerned is slap a few GCC developers (not that it wil help, but it'll certainly feel good) and then teach alpine to go for UTF-8 directly if US-ASCII won't do. As to the content of this patch -- I'd almost say it's better to live with the warning than with that unitialized_var() thing. That ARRAY_SIZE is very much a compile time constant, so exactly how dumb must GCC get before we get to say to here and no further? > --- linux-2.6.23-rc4-mm1/sound/isa/sb/sb16.c~fix 2007-09-02 21:41:51.000000000 +0530 > +++ linux-2.6.23-rc4-mm1/sound/isa/sb/sb16.c 2007-09-02 21:42:56.000000000 +0530 > @@ -556,7 +556,6 @@ static int __devinit snd_sb16_isa_match( > > static int __devinit snd_sb16_isa_probe(struct device *pdev, unsigned int dev) > { > - int err; > static int possible_irqs[] = {5, 9, 10, 7, -1}; > static int possible_dmas8[] = {1, 3, 0, -1}; > static int possible_dmas16[] = {5, 6, 7, -1}; > @@ -585,6 +584,8 @@ static int __devinit snd_sb16_isa_probe( > else { > static int possible_ports[] = {0x220, 0x240, 0x260, 0x280}; > int i; > + int uninitialized_var(err); > + > for (i = 0; i < ARRAY_SIZE(possible_ports); i++) { > port[dev] = possible_ports[i]; > err = snd_sb16_isa_probe1(dev, pdev); Rene.