From: Patrick McHardy <kaber@trash.net>
To: Thomas Graf <tgraf@suug.ch>
Cc: Netfilter Developer Mailing List
<netfilter-devel@lists.netfilter.org>,
Philip Craig <philipc@snapgear.com>
Subject: Re: [PATCH 1/3] libnl: add netfilter support
Date: Mon, 03 Sep 2007 12:06:51 +0200 [thread overview]
Message-ID: <46DBDCBB.8080903@trash.net> (raw)
In-Reply-To: <20070903100148.GG18480@postel.suug.ch>
Thomas Graf wrote:
> * Patrick McHardy <kaber@trash.net> 2007-09-03 11:50
>
>>Philip Craig wrote:
>>
>>>+#define NFA_NEST(skb, type) \
>>>+({ struct nfattr *__start = (struct nfattr *)skb_tail_pointer(skb); \
>>>+ NFA_PUT(skb, (NFNL_NFA_NEST | type), 0, NULL); \
>>>+ __start; })
>>
>>
>>The latest libnetfilter_conntrack version doesn't send the NFA_NEST
>>bit to the kernel anymore since we intend to get rid of it, at
>>least on the receive side. Please change this to not send it here
>>as well.
>
>
> Great, so basically the attribute interfaces could be merged on the
> sending side.
Yes, hopefully. We're using big endian for numeric values, but that
shouldn't be a problem I think.
> I think I can live with checking for the bit on the receiving side,
> the only problem it could cause is when the attribute type is used
> to encode information such as a port number. So if we are willing
> to take that risk the receiving path could be merged as well.
That kind of information should be stored as attribute value, no?
next prev parent reply other threads:[~2007-09-03 10:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-03 5:09 netfilter support in libnl Philip Craig
2007-09-03 5:11 ` [PATCH 1/3] libnl: add netfilter support Philip Craig
2007-09-03 9:50 ` Patrick McHardy
2007-09-03 10:01 ` Thomas Graf
2007-09-03 10:06 ` Patrick McHardy [this message]
2007-09-03 10:15 ` Thomas Graf
2007-09-03 10:53 ` Patrick McHardy
2007-09-03 11:03 ` Thomas Graf
2007-09-03 11:13 ` Patrick McHardy
2007-09-04 1:18 ` Philip Craig
2007-09-03 10:09 ` Thomas Graf
2007-09-04 2:12 ` Philip Craig
2007-09-04 9:39 ` Thomas Graf
2007-09-04 11:36 ` Thomas Graf
2007-09-03 5:11 ` [PATCH 2/3] libnl: add netfilter conntrack support Philip Craig
2007-09-04 16:45 ` Thomas Graf
2007-09-03 5:12 ` [PATCH 3/3] libnl: add netfilter log support Philip Craig
2007-09-04 16:48 ` Thomas Graf
2007-09-03 9:30 ` netfilter support in libnl Patrick McHardy
2007-09-03 9:59 ` Thomas Graf
2007-09-03 10:05 ` Patrick McHardy
2007-09-03 10:16 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DBDCBB.8080903@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=philipc@snapgear.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.