All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: 黃建興-Jesse <Jesse@icplus.com.tw>
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [patch 02/18] sundance: PHY address form 0, only for device I D 0x0200 (IP100A) (20070605)
Date: Mon, 03 Sep 2007 06:42:50 -0400	[thread overview]
Message-ID: <46DBE52A.2010207@garzik.org> (raw)
In-Reply-To: <AA68EB0EBA29BA40A06B700C33343EEF018686BB@fileserver.icplus.com.tw>

黃建興-Jesse wrote:
> +++ a/drivers/net/sundance.c
> @@ -559,7 +559,11 @@ static int __devinit sundance_probe1 (st
>          * It seems some phys doesn't deal well with address 0 being 
> accessed
>          * first, so leave address zero to the end of the loop (32 & 31).
>          */
> -       for (phy = 1; phy <= 32 && phy_idx < MII_CNT; phy++) {
> +       if (sundance_pci_tbl[np->chip_id].device == 0x0200)
> +               phy = 0;
> +       else
> +               phy = 1;
> +       for (; phy <= 32 && phy_idx < MII_CNT; phy++) {


As I noted in the last email, this patch still has a bug:

In the above loop code being modified, you need to change two things:

1) Initial loop value
2) Loop terminating condition

Your patch only performs change #1.

	Jeff



       reply	other threads:[~2007-09-03 10:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AA68EB0EBA29BA40A06B700C33343EEF018686BB@fileserver.icplus.com.tw>
2007-09-03 10:42 ` Jeff Garzik [this message]
2007-09-05 18:39 [patch 02/18] sundance: PHY address form 0, only for device I D 0x0200 (IP100A) (20070605) Jesse Huang
     [not found] <AA68EB0EBA29BA40A06B700C33343EEF018686DF@fileserver.icplus.com.tw>
2007-09-07 23:23 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46DBE52A.2010207@garzik.org \
    --to=jeff@garzik.org \
    --cc=Jesse@icplus.com.tw \
    --cc=akpm@linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.