From: Patrick McHardy <kaber@trash.net>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] fix net_device leak in vlan
Date: Mon, 03 Sep 2007 16:23:05 +0200 [thread overview]
Message-ID: <46DC18C9.8090501@trash.net> (raw)
In-Reply-To: <20070903133520.GV21089@ftp.linux.org.uk>
Al Viro wrote:
> In "[VLAN]: Move device registation to seperate function" (commit
> e89fe42cd03c8fd3686df82d8390a235717a66de), a pile of code got moved
> to register_vlan_dev(), including grabbing a reference to underlying
> device. However, original dev_hold() had been left behind, so we
> leak a reference to net_device now...
Looks good, thanks for catching this.
next prev parent reply other threads:[~2007-09-03 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-03 13:35 [PATCH] fix net_device leak in vlan Al Viro
2007-09-03 14:23 ` Patrick McHardy [this message]
2007-09-16 23:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DC18C9.8090501@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.