All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <j.w.r.degoede@hhs.nl>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 7/7] libsensors4: Don't store scaling
Date: Mon, 03 Sep 2007 17:53:05 +0000	[thread overview]
Message-ID: <46DC4A01.30805@hhs.nl> (raw)
In-Reply-To: <20070902222333.6a46e91b@hyperion.delvare>

Jean Delvare wrote:
> Now that we can deduce the scaling factor required for each feature
> from its type, there's no need to store this scaling factor. We can
> instead compute it at runtime. This saves some memory (about 10 kB
> in my real-world test), and the runtime overhead is totally
> negligible.
> 

Looks good.

> Note that the structures sensors_chip_feature and sensors_feature_data
> are now exactly the same, so we could use one structure everywhere.
> The only advantage to have two structures is that sensors_feature_data
> is part of the API, while sensors_chip_feature is not, so if we
> ever need to add internal attributes, for example to improve performance,
> having an internal structure can be helpful. Question is, will we
> actually ever need this? Opinion anyone?
> 

I think it would be better to make them one and the same structure then, to 
avoid confusion.

Regards,

Hans


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2007-09-03 17:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-02 20:23 [lm-sensors] [PATCH 7/7] libsensors4: Don't store scaling factors Jean Delvare
2007-09-03 17:53 ` Hans de Goede [this message]
2007-09-04  8:35 ` [lm-sensors] [PATCH 7/7] libsensors4: Don't store scaling Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46DC4A01.30805@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.