All of lore.kernel.org
 help / color / mirror / Atom feed
From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] Export format_commit_message()
Date: Mon, 03 Sep 2007 20:44:10 +0200	[thread overview]
Message-ID: <46DC55FA.6040905@lsrfire.ath.cx> (raw)
In-Reply-To: <Pine.LNX.4.64.0709031934480.28586@racer.site>

Johannes Schindelin schrieb:
>> -static long format_commit_message(const struct commit *commit,
>> -		const char *msg, char **buf_p, unsigned long *space_p)
>> +long format_commit_message(const struct commit *commit, const void *template,
>> +                           char **buf_p, unsigned long *space_p)
> 
> I am quite sure that this breaks compilation in C++.
> 
> Besides, "format" is so much more descriptive here IMHO.  What is so wrong 
> with "format" for you?

I have nothing against naming the parameter "format", actually.  This
name simply didn't occur to me -- weird but true. :-]

René

      reply	other threads:[~2007-09-03 18:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-03 18:06 [PATCH 1/3] Export format_commit_message() René Scharfe
2007-09-03 18:35 ` Johannes Schindelin
2007-09-03 18:44   ` René Scharfe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46DC55FA.6040905@lsrfire.ath.cx \
    --to=rene.scharfe@lsrfire.ath.cx \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.