From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: Re: [-mm PATCH] Memory controller improve user interface (v3) Date: Mon, 03 Sep 2007 20:45:10 +0100 Message-ID: <46DC6446.1080707@linux.vnet.ibm.com> References: <20070902105021.3737.31251.sendpatchset@balbir-laptop> <6599ad830709022153g1720bcedsb61d7cf7a783bd3f@mail.gmail.com> Reply-To: balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6599ad830709022153g1720bcedsb61d7cf7a783bd3f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Paul Menage Cc: Linux Kernel Mailing List , Linux MM Mailing List , David Rientjes , Linux Containers , Andrew Morton List-Id: containers.vger.kernel.org Paul Menage wrote: > On 9/2/07, Balbir Singh wrote: >> - s += sprintf(s, "%lu\n", *val); >> + if (read_strategy) >> + s += read_strategy(*val, s); >> + else >> + s += sprintf(s, "%lu\n", *val); > > This would be better as %llu > >> + tmp = simple_strtoul(buf, &end, 10); > > and this as simple_strtoull() > > Paul > Thanks for catching it, I'll fix that. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756558AbXICTq7 (ORCPT ); Mon, 3 Sep 2007 15:46:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754745AbXICTqw (ORCPT ); Mon, 3 Sep 2007 15:46:52 -0400 Received: from E23SMTP04.au.ibm.com ([202.81.18.173]:49734 "EHLO e23smtp04.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753891AbXICTqv (ORCPT ); Mon, 3 Sep 2007 15:46:51 -0400 Message-ID: <46DC6446.1080707@linux.vnet.ibm.com> Date: Mon, 03 Sep 2007 20:45:10 +0100 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com Organization: IBM User-Agent: Thunderbird 1.5.0.13 (X11/20070824) MIME-Version: 1.0 To: Paul Menage CC: Andrew Morton , Linux Kernel Mailing List , Linux Containers , Linux MM Mailing List , David Rientjes , Dave Hansen Subject: Re: [-mm PATCH] Memory controller improve user interface (v3) References: <20070902105021.3737.31251.sendpatchset@balbir-laptop> <6599ad830709022153g1720bcedsb61d7cf7a783bd3f@mail.gmail.com> In-Reply-To: <6599ad830709022153g1720bcedsb61d7cf7a783bd3f@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Paul Menage wrote: > On 9/2/07, Balbir Singh wrote: >> - s += sprintf(s, "%lu\n", *val); >> + if (read_strategy) >> + s += read_strategy(*val, s); >> + else >> + s += sprintf(s, "%lu\n", *val); > > This would be better as %llu > >> + tmp = simple_strtoul(buf, &end, 10); > > and this as simple_strtoull() > > Paul > Thanks for catching it, I'll fix that. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [202.81.18.234]) by e23smtp05.au.ibm.com (8.13.1/8.13.1) with ESMTP id l83JjYvC030553 for ; Tue, 4 Sep 2007 05:45:34 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.250.244]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l83JjVrT4460636 for ; Tue, 4 Sep 2007 05:45:32 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l83JjVix028481 for ; Tue, 4 Sep 2007 05:45:31 +1000 Message-ID: <46DC6446.1080707@linux.vnet.ibm.com> Date: Mon, 03 Sep 2007 20:45:10 +0100 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com MIME-Version: 1.0 Subject: Re: [-mm PATCH] Memory controller improve user interface (v3) References: <20070902105021.3737.31251.sendpatchset@balbir-laptop> <6599ad830709022153g1720bcedsb61d7cf7a783bd3f@mail.gmail.com> In-Reply-To: <6599ad830709022153g1720bcedsb61d7cf7a783bd3f@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Paul Menage Cc: Andrew Morton , Linux Kernel Mailing List , Linux Containers , Linux MM Mailing List , David Rientjes , Dave Hansen List-ID: Paul Menage wrote: > On 9/2/07, Balbir Singh wrote: >> - s += sprintf(s, "%lu\n", *val); >> + if (read_strategy) >> + s += read_strategy(*val, s); >> + else >> + s += sprintf(s, "%lu\n", *val); > > This would be better as %llu > >> + tmp = simple_strtoul(buf, &end, 10); > > and this as simple_strtoull() > > Paul > Thanks for catching it, I'll fix that. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org