From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Zachary Amsden <zach@vmware.com>,
Linus Torvalds <torvalds@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Chris Wright <chrisw@sous-sol.org>,
stable@kernel.org,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Andi Kleen <ak@suse.de>, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH] Fix preemptible lazy mode bug
Date: Tue, 04 Sep 2007 14:42:01 +0100 [thread overview]
Message-ID: <46DD60A9.8080203@goop.org> (raw)
In-Reply-To: <1188850468.10802.66.camel@localhost.localdomain>
Rusty Russell wrote:
> static inline void arch_flush_lazy_mmu_mode(void)
> {
> - PVOP_VCALL1(set_lazy_mode, PARAVIRT_LAZY_FLUSH);
> + if (unlikely(__get_cpu_var(paravirt_lazy_mode) == PARAVIRT_LAZY_MMU))
> + arch_leave_lazy_mmu_mode();
> }
>
This changes the semantics a bit; previously "flush" would flush
anything pending but leave us in lazy mode. This just drops lazymode
altogether?
I guess if we assume that flushing is a rare event then its OK, but I
think the name's a bit misleading. How does it differ from plain
arch_leave_lazy_mmu_mode()?
J
next prev parent reply other threads:[~2007-09-04 13:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 5:46 [PATCH] Fix preemptible lazy mode bug Zachary Amsden
2007-08-24 6:53 ` Jeremy Fitzhardinge
2007-08-24 6:59 ` Zachary Amsden
2007-08-25 11:57 ` Rusty Russell
2007-09-01 21:09 ` Jeremy Fitzhardinge
2007-09-01 21:09 ` Jeremy Fitzhardinge
2007-09-03 20:14 ` Rusty Russell
2007-09-04 13:42 ` Jeremy Fitzhardinge [this message]
2007-09-05 16:33 ` Rusty Russell
2007-09-05 17:05 ` Zachary Amsden
2007-09-05 17:48 ` Rusty Russell
2007-09-05 20:10 ` Jeremy Fitzhardinge
2007-09-05 20:37 ` Rusty Russell
2007-09-05 23:49 ` Zachary Amsden
2007-09-06 5:41 ` Andi Kleen
2007-09-06 9:56 ` Jeremy Fitzhardinge
2007-09-06 9:57 ` Jeremy Fitzhardinge
-- strict thread matches above, loose matches on Subject: below --
2007-08-24 5:46 Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DD60A9.8080203@goop.org \
--to=jeremy@goop.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=anthony@codemonkey.ws \
--cc=chrisw@sous-sol.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=stable@kernel.org \
--cc=torvalds@osdl.org \
--cc=virtualization@lists.osdl.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.