From: Johannes Sixt <j.sixt@eudaptics.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Carlos Rica <jasampler@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] Functions for updating refs.
Date: Tue, 04 Sep 2007 17:08:54 +0200 [thread overview]
Message-ID: <46DD7506.3090503@eudaptics.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0709041557590.28586@racer.site>
Johannes Schindelin schrieb:
> Hi,
>
> On Tue, 4 Sep 2007, Johannes Sixt wrote:
>
>> Johannes Schindelin schrieb:
>>> On Tue, 4 Sep 2007, Carlos Rica wrote:
>>>> +int update_ref_or_die(const char *action, const char *refname,
>>>> + const unsigned char *sha1,
>>>> + const unsigned char *oldval, int flags)
>>> Should this not be "void"? And should it not use update_ref_or_error()?
>> It should not use *_error() directly because then it would print two error
>> messages in a row.
>
> Well, my idea was to let _error() print the message, and just die().
How do you avoid that die() prints an error, too?
-- Hannes
next prev parent reply other threads:[~2007-09-04 15:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 13:39 [PATCH] Functions for updating refs Carlos Rica
2007-09-04 13:45 ` Johannes Schindelin
2007-09-04 14:28 ` Johannes Sixt
2007-09-04 14:58 ` Johannes Schindelin
2007-09-04 15:08 ` Johannes Sixt [this message]
2007-09-04 15:29 ` Karl Hasselström
2007-09-04 15:33 ` Johannes Schindelin
2007-09-04 17:52 ` Junio C Hamano
2007-09-04 23:32 ` Carlos Rica
2007-09-05 0:16 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DD7506.3090503@eudaptics.com \
--to=j.sixt@eudaptics.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jasampler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.