From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [PATCH][Retry 1] 4/4: cpufreq/PowerNow! in Xen: PowerNow! changes Date: Tue, 04 Sep 2007 13:08:02 -0400 Message-ID: <46DD90F2.4070505@redhat.com> References: <200708301201.32030.mark.langsdorf@amd.com> <1449F58C868D8D4E9C72945771150BDF0207700F@SAUSEXMB1.amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449F58C868D8D4E9C72945771150BDF0207700F@SAUSEXMB1.amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Langsdorf, Mark" Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Langsdorf, Mark wrote: >> On 30/8/07 18:01, "Mark Langsdorf" wrote: >> >>> Patch 4 covers the changes necessary to the PowerNow! driver >>> to make it correctly associate shared cores under Xen. >> Should we have a copy of that file in powernow-k8-xen.c? Can >> the patched file work correctly in a native Linux build? > > If I need to change one function in > driver/cpufreq/cpufreq_ondemand.c (to use Rik's new getidletime > platform hypercall), do I need to make an entire new file or > can I just add it inline? #ifdef is no Linux favorite, but it is far better than cloning a file. -- Politics is the struggle between those who want to make their country the best in the world, and those who believe it already is. Each group calls the other unpatriotic.