From: Rene Herman <rene.herman@gmail.com>
To: Krzysztof Helt <krzysztof.h1@wp.pl>
Cc: Alsa-devel <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] sgalaxy: checkpatch fixes
Date: Wed, 05 Sep 2007 14:23:09 +0200 [thread overview]
Message-ID: <46DE9FAD.8020909@gmail.com> (raw)
In-Reply-To: <20070905064758.9965e781.krzysztof.h1@wp.pl>
On 09/05/2007 06:47 AM, Krzysztof Helt wrote:
> I about acquring the SG Waverider card. I saw your driver and thought
> about asking you to cooperate to merge you driver into the sgalaxy or
> polish the driver more. You are just one step before me.
Ah, recently grabbed a Waverider as well. I now have some 15 Sound Galaxy
models I believe which is partly why testing them all is taking too
much/long ;-)
Will make time now though.
> Yes, but as I am about merging your patch into the sgalaxy
> (my first idea).
> I want to avoid situation with patches being rejected due
> to coding style problem in context lines.
Nah, really the only "important" thing is (while you're there) to do the "if
((err = ))" breaking -- noone here is religious about the rest.
But, well, forgetting all about sgalaxy.c makes as much sense. The new
driver already support more models anyway (the ones without EEPROMs).
Rene.
next prev parent reply other threads:[~2007-09-05 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 21:49 [PATCH] sgalaxy: checkpatch fixes Krzysztof Helt
2007-09-04 22:24 ` Rene Herman
2007-09-05 4:47 ` Krzysztof Helt
2007-09-05 12:23 ` Rene Herman [this message]
2007-09-05 13:20 ` Takashi Iwai
2007-09-05 13:34 ` Krzysztof Helt
2007-09-05 13:32 ` Rene Herman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DE9FAD.8020909@gmail.com \
--to=rene.herman@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=krzysztof.h1@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.