All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@smiths-aerospace.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] fdt command: can't set a value-less property
Date: Thu, 06 Sep 2007 09:54:43 -0400	[thread overview]
Message-ID: <46E006A3.6090406@smiths-aerospace.com> (raw)
In-Reply-To: <46E0043F.6070906@semihalf.com>

Bartlomiej Sieka wrote:
> Hello,
> 
> I'm playing with the fdt command in recent (60174746) U-Boot and I can't
> set a property that does not have a value.
> Documentation/powerpc/booting-without-of.txt" says "A property can have
> a value or not.", and fdt help suggests the same:
> fdt set    <path> <prop> [<val>]    - Set <property> [to <val>]
> 
> However, I am getting:
> 
> => fdt mknode / testnode
> => fdt list /testnode
> testnode {
> };
> => fdt set /testnode testprop
> Usage:
> fdt     - flattened device tree utility commands
> 
> => fdt list /testnode
> testnode {
> };
> 
> Setting a property with value works:
> 
> => fdt set /testnode testprop "testvalue"
> => fdt list /testnode
> testnode {
>          testprop=""testvalue"";
> };
> 
> Am I doing something wrong, or is it a bug?
> 
> Regards,
> Bartlomiej

Hi Bartlomiej,

That looks like a bug.  The cmd_fdt.c parser looks like it is insisting 
on a value (looking for three parameters to the "fdt set" subcommand).

I have not looked at the code to confirm the above hypothesis yet...

Best regards,
gvb

  reply	other threads:[~2007-09-06 13:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-06 13:44 [U-Boot-Users] fdt command: can't set a value-less property Bartlomiej Sieka
2007-09-06 13:54 ` Jerry Van Baren [this message]
2007-09-06 15:15   ` Bartlomiej Sieka
2007-09-06 15:20     ` Jerry Van Baren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E006A3.6090406@smiths-aerospace.com \
    --to=gerald.vanbaren@smiths-aerospace.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.