Re: [PATCH] Gallant SC-6000 driver (4th version)

[Rene Herman <rene.herman@gmail.com>]

On 09/07/2007 01:11 PM, Takashi Iwai wrote:

> The codes used for this auto-probing is relatively small and easy, so
> as Rene expected, I don't mind about it :)
> 
> The criterion is only whether it's _really_ useful and works without
> hitch.

Exactly. Krysztof snipped most of my objections but we are talking about 
legacy ISA hardware here. So imagine you have _another_ piece of legacy ISA 
hardware sitting on say IRQ 5. Unless you load your driver after the driver 
for the other bit of hardware is loaded, your driver finds IRQ 5 free, grabs 
it and configures the card for IRQ 5, after which your nor the other piece 
of hardware work anymore.

At this point, you've helped this poor unaware user from the docks into the 
harbour as he has no idea what's going on, having not specified anything 
himself.

I'll repeat -- there's really no defending that massive junk :-)

> We keep the old code as is just because it was worked, and we shouldn't
> break it.  The concept is not perfect, but if it practically works, I
> have no objection.

What practically works is sticking an options line in modprobe.conf...

But hey, I'm aware some people think it helps. As long as you are aware 
you're wrong and that it _is_ massive junk, I'm halfway content :-)

Rene.