From: Rene Herman <rene.herman@gmail.com>
To: Krzysztof Helt <krzysztof.h1@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>, Alsa-devel <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] cs4231-lib: improved waiting after mce_down (2nd rev)
Date: Tue, 11 Sep 2007 00:43:42 +0200 [thread overview]
Message-ID: <46E5C89E.4010607@gmail.com> (raw)
In-Reply-To: <20070911004010.b9114b3e.krzysztof.h1@gmail.com>
On 09/11/2007 12:40 AM, Krzysztof Helt wrote:
> This patch replaces long msleeps in waiting loops
> with schedule_timeout() calls.
Hope you'll not detest me for getting on your case so much, but...
First, yes, attachments are good as far as I'm concerned, but could you make
them plain text attachments? They are now Base64 which means that at least
with my "casual mailer" (Thunderbird) I need to save the patch and can only
then look at it.
Second -- not schedule_timeout_interruptible? A plain schedule_timeout won't
work, as you first need to __set_current_state or it will not schedule. That
is, schedule_timeout_interruptible or _uniterruptible and with the latter,
the loop wouldn't make much sense anymore as it's just going to sleep for
the full 250 ms directly.
Rene.
next prev parent reply other threads:[~2007-09-10 22:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-09 20:11 [PATCH] cs4231-lib: improved waiting after mce_down Krzysztof Helt
2007-09-10 21:31 ` Takashi Iwai
2007-09-10 22:40 ` [PATCH] cs4231-lib: improved waiting after mce_down (2nd rev) Krzysztof Helt
2007-09-10 22:41 ` Takashi Iwai
2007-09-10 22:43 ` Rene Herman [this message]
2007-09-10 23:08 ` Takashi Iwai
2007-09-10 23:17 ` Takashi Iwai
2007-09-11 0:40 ` Rene Herman
2007-09-11 4:52 ` Krzysztof Helt
2007-09-11 8:39 ` Krzysztof Helt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E5C89E.4010607@gmail.com \
--to=rene.herman@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=krzysztof.h1@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.