Re: [PATCH 12/19] NFS/SUNRPC: support transport protocol naming

[Chuck Lever <chuck.lever@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

Talpey, Thomas wrote:
> At 08:25 PM 9/10/2007, Chuck Lever wrote:
>> Just a general comment.
>>
>> I don't see how this will make it easier to add NFS client support for 
>> new RPC transports.  I thought we recently decided to pass down a 
>> string, and let the transports themselves register a netid that matches it?
>>
>> For example, these changes are required to support RDMA -- you can't 
>> just ship a new RDMA SUNRPC transport module and expect it to work 
>> without this ULP change.  Likewise, if we add SCTP sometime in the 
>> future, will we want to make this same kind of modification to the NFS 
>> client before the SCTP SUNRCP transport module works correctly?
> 
> Well, the "string" discussion was in the context of the server-side
> switch,

Oops.  I thought it was about both sides.

> but you call out a good goal to add transports without touching
> the upper layers.
> 
> I think the choice of integer or string is basically arbitrary. One way or
> the other, some mapping from identifier to the actual transport is defined.
> Strings are a little more self-describing, but in the end harder to maintain
> for that very reason. That's the way my thinking came down, anyway.

I guess I see it the other way.  The user specifies a string. 
Converting it to a number means something has to keep track of the mapping.

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 290 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs