From: Boaz Harrosh <bharrosh@panasas.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
linux-scsi <linux-scsi@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Matthew Dharm <mdharm-usb@one-eyed-alien.net>,
Russell King <rmk@arm.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH ver3 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd()
Date: Tue, 11 Sep 2007 20:38:42 +0300 [thread overview]
Message-ID: <46E6D2A2.5000300@panasas.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0709111138460.3852-100000@iolanthe.rowland.org>
On Tue, Sep 11 2007 at 18:41 +0300, Alan Stern <stern@rowland.harvard.edu> wrote:
> On Tue, 11 Sep 2007, Boaz Harrosh wrote:
>
>> - regrouped variables for easier reviewing of next patch
>> - Support of cmnd==NULL in call to scsi_send_eh_cmnd()
>> - In the copy_sense case set transfer size to the minimum
>> size of sense_buffer and passed @sense_bytes. cmnd[4] is
>> set accordingly.
>> - REQUEST_SENSE is set into cmnd[0] so if @sense_bytes is
>> not Zero passed cmnd can/should be NULL.
>> - Also save/restore resid of faild command.
>
> The "if (sense_bytes)" block doesn't set scmd->cmd_len. Yes, I know
> that value gets changed by the usb-storage driver, but nevertheless it
> should be set here to 6.
>
> Apart from that, this looks fine to me.
>
> Alan Stern
>
Thanks a million. The 22:45 effect again.
Will patch ver4 of this patch as reply to
first one.
Boaz
next prev parent reply other threads:[~2007-09-11 17:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-10 19:13 [patchset ver2 0/5] Refactoring scsi_error to facilitate in synchronous REQUEST_SENSE Boaz Harrosh
2007-09-10 19:34 ` [PATCH ver2 1/5] scsi_error: code cleanup before refactoring of scsi_send_eh_cmnd() Boaz Harrosh
2007-09-11 8:03 ` [PATCH ver3 " Boaz Harrosh
2007-09-11 8:11 ` Julian Calaby
2007-09-11 8:54 ` Benny Halevy
2007-09-11 15:41 ` Alan Stern
2007-09-11 17:38 ` Boaz Harrosh [this message]
2007-09-11 17:39 ` [PATCH ver4 " Boaz Harrosh
2007-10-03 15:55 ` James Bottomley
2007-10-08 14:29 ` Boaz Harrosh
2007-10-08 14:35 ` [PATCH ver5 " Boaz Harrosh
2007-09-10 19:35 ` [PATCH ver2 2/5] scsi_error: Refactoring scsi_error to facilitate in synchronous REQUEST_SENSE Boaz Harrosh
2007-09-10 21:15 ` Matthew Dharm
2007-09-11 8:00 ` Boaz Harrosh
2007-09-11 8:04 ` [PATCH ver3 " Boaz Harrosh
2007-10-03 15:59 ` James Bottomley
2007-10-08 14:36 ` [PATCH ver5 " Boaz Harrosh
2007-09-10 19:36 ` [PATCH ver2 3/5] usb: transport.c use scsi_eh API in REQUEST_SENSE execution Boaz Harrosh
2007-09-10 19:37 ` [PATCH ver2 4/5] NCR5380: Use scsi_eh API for REQUEST_SENSE invocation Boaz Harrosh
2007-09-10 19:39 ` [PATCH ver2 5/5] arm: fas216 " Boaz Harrosh
2007-09-12 7:44 ` Russell King
2007-09-12 8:15 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E6D2A2.5000300@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@SteelEye.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=gregkh@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=rdunlap@xenotime.net \
--cc=rmk@arm.linux.org.uk \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.