From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: Re: [PATCH 23/29] memory controller memory accounting v7 Date: Thu, 13 Sep 2007 15:59:08 +0530 Message-ID: <46E910F4.2000207@linux.vnet.ibm.com> References: <20070911195239.997111000@menage.corp.google.com> <20070911200148.396756000@menage.corp.google.com> <1189630610.5597.10.camel@lappy> <46E9078D.5040908@linux.vnet.ibm.com> <1189678681.21778.191.camel@twins> Reply-To: balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1189678681.21778.191.camel@twins> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Peter Zijlstra Cc: Nick Piggin , "Eric W. Biederman" , David Rientjes , containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, Andrew Morton , Pavel Emelianov List-Id: containers.vger.kernel.org Peter Zijlstra wrote: > On Thu, 2007-09-13 at 15:19 +0530, Balbir Singh wrote: > >> VM_BUG_ON(pc && !locked) > > Even better :-) > Good, I'll change it. >> I am not sure I understand this comment. > > Is that inc needed? the pc is already associated with the page and > should thus already have a reference, so this inc would do 1->2, but we > then set it to 1 again. seems like a superfluous operation. That is something I need to look into. I'll try and get to it soon. -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL