All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Bill Nottingham <notting@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add CONFIG_VT_UNICODE
Date: Thu, 13 Sep 2007 08:10:16 -0700	[thread overview]
Message-ID: <46E952D8.2000203@zytor.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0709071348090.25942@fbirervta.pbzchgretzou.qr>

Jan Engelhardt wrote:
> On Aug 31 2007 16:18, Bill Nottingham wrote:
>> As of now, the kernel defaults to non-unicode and XLATE for the keyboard.
>> We've been changing this in Fedora, but that requires patching the defaults
>> in the kernel.
>>
>> The attached introduces CONFIG_VT_UNICODE, which sets the console in unicode
>> mode by default on boot, including both the virtual terminal and the keyboard
>> driver.
> 
> I would prefer to:
>  - make default_utf=1 in the source
>  - add "default_utf8 ? VC_UNICODE : VC_XLATE" to the keyboard code
>    as your patch does
>  - and do away with the new CONFIG_ option, since, surprise, surprise,
>    you can change it at runtime, so there is no need to do it
>    at compile-time too.
> 

I concur.

	-hpa

      reply	other threads:[~2007-09-13 15:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-31 20:18 [PATCH] add CONFIG_VT_UNICODE Bill Nottingham
2007-08-31 20:24 ` Randy Dunlap
2007-08-31 20:28   ` Bill Nottingham
2007-08-31 20:33     ` Randy Dunlap
2007-09-01 21:11 ` H. Peter Anvin
2007-09-06 12:06   ` Jan Engelhardt
2007-09-06 14:06     ` H. Peter Anvin
2007-09-07  0:26       ` Bill Nottingham
2007-09-07 11:47       ` Jan Engelhardt
2007-09-07 11:49 ` Jan Engelhardt
2007-09-13 15:10   ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46E952D8.2000203@zytor.com \
    --to=hpa@zytor.com \
    --cc=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=notting@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.