From: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>, xen-devel@lists.xensource.com
Subject: [PATCH] qemu-dm: Fix Raw Block IO Debug Print
Date: Fri, 14 Sep 2007 10:32:46 +0900 [thread overview]
Message-ID: <46E9E4BE.1030408@ab.jp.nec.com> (raw)
In-Reply-To: <20070913110235.GG2700%yamahata@valinux.co.jp>
[-- Attachment #1: Type: text/plain, Size: 480 bytes --]
Isaku Yamahata wrote:
> On Thu, Sep 13, 2007 at 07:23:59PM +0900, Yosuke Iwamatsu wrote:
>> Hi,
>>
>> This is a trivial fix for debug print formats of raw block io.
>> Without this patch, qemu-dm occasionally gets stuck
>> when a raw io device is inaccessible (eg. CR-ROM doesn't exist).
>
> Hi.
> PRId64 should be used for int64_t instead of lld.
>
Thank you for the comment.
Attached is a revised patch.
Regards,
-------------------
Yosuke Iwamatsu
NEC Corporation
[-- Attachment #2: fix_block_raw_print_r1.patch --]
[-- Type: text/plain, Size: 2691 bytes --]
# HG changeset patch
# User Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
# Date 1189733245 -32400
# Node ID 0b5035b9e80ac8371269dc6b8a59cd4122d46f1f
# Parent a00cc97b392a8e845f26f05817ffe1edcf8878d6
qemu-dm: fix block-raw io debug print
Signed-off-by: Yosuke Iwamatsu <y-iwamatsu@ab.jp.nec.com>
diff -r a00cc97b392a -r 0b5035b9e80a tools/ioemu/block-raw.c
--- a/tools/ioemu/block-raw.c Wed Sep 12 09:43:33 2007 +0100
+++ b/tools/ioemu/block-raw.c Fri Sep 14 10:27:25 2007 +0900
@@ -150,7 +150,7 @@ static int raw_pread(BlockDriverState *b
if (lseek(s->fd, offset, SEEK_SET) == (off_t)-1) {
++(s->lseek_err_cnt);
if(s->lseek_err_cnt <= 10) {
- DEBUG_BLOCK_PRINT("raw_pread(%d:%s, %ld, %p, %d) [%ld] lseek failed : %d = %s\n",
+ DEBUG_BLOCK_PRINT("raw_pread(%d:%s, %" PRId64 ", %p, %d) [%" PRId64 "] lseek failed : %d = %s\n",
s->fd,
bs->filename,
offset,
@@ -166,7 +166,7 @@ static int raw_pread(BlockDriverState *b
if (ret == count)
goto label__raw_read__success;
- DEBUG_BLOCK_PRINT("raw_read(%d:%s, %ld, %p, %d) [%ld] read failed %d : %d = %s\n",
+ DEBUG_BLOCK_PRINT("raw_read(%d:%s, %" PRId64 ", %p, %d) [%" PRId64 "] read failed %d : %d = %s\n",
s->fd,
bs->filename,
offset,
@@ -185,7 +185,7 @@ static int raw_pread(BlockDriverState *b
if (ret == count)
goto label__raw_read__success;
- DEBUG_BLOCK_PRINT("raw_read(%d:%s, %ld, %p, %d) [%ld] retry read failed %d : %d = %s\n",
+ DEBUG_BLOCK_PRINT("raw_read(%d:%s, %" PRId64 ", %p, %d) [%" PRId64 "] retry read failed %d : %d = %s\n",
s->fd,
bs->filename,
offset,
@@ -215,7 +215,7 @@ static int raw_pwrite(BlockDriverState *
if (lseek(s->fd, offset, SEEK_SET) == (off_t)-1) {
++(s->lseek_err_cnt);
if(s->lseek_err_cnt) {
- DEBUG_BLOCK_PRINT("raw_write(%d:%s, %ld, %p, %d) [%ld] lseek failed : %d = %s\n",
+ DEBUG_BLOCK_PRINT("raw_write(%d:%s, %" PRId64 ", %p, %d) [%" PRId64 "] lseek failed : %d = %s\n",
s->fd,
bs->filename,
offset,
@@ -231,7 +231,7 @@ static int raw_pwrite(BlockDriverState *
if (ret == count)
goto label__raw_write__success;
- DEBUG_BLOCK_PRINT("raw_write(%d:%s, %ld, %p, %d) [%ld] write failed %d : %d = %s\n",
+ DEBUG_BLOCK_PRINT("raw_write(%d:%s, %" PRId64 ", %p, %d) [%" PRId64 "] write failed %d : %d = %s\n",
s->fd,
bs->filename,
offset,
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
prev parent reply other threads:[~2007-09-14 1:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 10:23 [PATCH] qemu-dm: Fix Raw Block IO Debug Print Yosuke Iwamatsu
2007-09-13 11:02 ` Isaku Yamahata
2007-09-14 1:32 ` Yosuke Iwamatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46E9E4BE.1030408@ab.jp.nec.com \
--to=y-iwamatsu@ab.jp.nec.com \
--cc=xen-devel@lists.xensource.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.