All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Wei Huang <wei.huang2-5C7GfCeVMHo@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [ANNOUNCE] kvm-36 release
Date: Fri, 14 Sep 2007 20:19:30 +0300	[thread overview]
Message-ID: <46EAC2A2.1060607@qumranet.com> (raw)
In-Reply-To: <46E86244.8070107-5C7GfCeVMHo@public.gmane.org>

Wei Huang wrote:
> The compilation errors also showed up on my boxes. The attached patch
> fixes the errors by renaming variables.
>
> Signed-off-by: Wei Huang <wei.huang2-5C7GfCeVMHo@public.gmane.org>
> diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
> index 99e4917..f04ca6b 100644
> --- a/drivers/kvm/kvm_main.c
> +++ b/drivers/kvm/kvm_main.c
> @@ -2967,25 +2967,25 @@ static long kvm_vcpu_ioctl(struct file *
>  		break;
>  	}
>  	case KVM_GET_LAPIC: {
> -		struct kvm_lapic_state lapic;
> +		struct kvm_lapic_state lapic_state;
>  
> -		memset(&lapic, 0, sizeof lapic);
> -		r = kvm_vcpu_ioctl_get_lapic(vcpu, &lapic);
> +		memset(&lapic_state, 0, sizeof lapic_state);
> +		r = kvm_vcpu_ioctl_get_lapic(vcpu, &lapic_state);
>  		if (r)

I committed an equivalent fix, but one that only affects the external
module, since the issue is not present with current kernels.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  parent reply	other threads:[~2007-09-14 17:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12 14:13 [ANNOUNCE] kvm-36 release Avi Kivity
     [not found] ` <46E7F417.6020107-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-12 14:14   ` Avi Kivity
     [not found]     ` <46E7F44C.9070303-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-12 15:08       ` Piero Ottuzzi
     [not found]         ` <200709121708.51719.ottuzzi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2007-09-12 22:03           ` Wei Huang
     [not found]             ` <46E86244.8070107-5C7GfCeVMHo@public.gmane.org>
2007-09-14 17:19               ` Avi Kivity [this message]
2007-09-12 16:13       ` Gildas
     [not found]         ` <b2ace7f20709120913wf08b91brb7a2f73b608a3bac-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-09-14 16:53           ` Avi Kivity
  -- strict thread matches above, loose matches on Subject: below --
2007-08-22 15:17 Avi Kivity
     [not found] ` <46CC537D.4030402-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-22 18:50   ` Gunther Persoons
     [not found]     ` <b0a37f790708221150i54949b71ocfe49b18546f4ad6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-22 19:12       ` Haydn Solomon
     [not found]         ` <b75785ba0708221212k458e0635n3b37a18aeec0a696-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-22 19:20           ` Fabian Deutsch
2007-08-22 19:29       ` Duncan McQueen
     [not found]         ` <494f8120708221229w571845b0wf406828a34209de6-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-22 19:33           ` Gunther Persoons
     [not found]             ` <b0a37f790708221233n398d7424w30ed6ecbd04bd15f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-22 19:50               ` Haydn Solomon
2007-08-23  7:43       ` Avi Kivity
     [not found]         ` <46CD3AA7.7010903-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-23  8:12           ` Avi Kivity
     [not found]             ` <46CD4156.2000506-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-23  0:36               ` Izik Eidus
     [not found]                 ` <1187829365.2730.4.camel-siXIhNkUrCXckEVJwWePHtCfPAL7FxvL@public.gmane.org>
2007-08-23  0:37                   ` Izik Eidus
2007-08-23 11:01                   ` Avi Kivity
2007-08-23  9:02               ` Gunther Persoons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46EAC2A2.1060607@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=wei.huang2-5C7GfCeVMHo@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.