From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH 5/4] simplify xfs_create/mknod/symlink prototype
Date: Fri, 14 Sep 2007 13:34:26 -0500 [thread overview]
Message-ID: <46EAD432.1030704@sandeen.net> (raw)
In-Reply-To: <46EAD364.7060305@sandeen.net>
Eric Sandeen wrote:
> Christoph Hellwig wrote:
>> (sorry, go the patch numbering one off)
>>
>> Simplify the prototype for xfs_create/xfs_mkdir/xfs_symlink by not
>> passing down a bhv_vattr_t that just hogs stack space. Instead pass
>> down the mode in a mode_t and in case of xfs_crate the rdev as a scalar
>> type aswell.
>
> With this whole patch series, I see these stack reductions on my x86
> box, nice!
>
> -xfs_symlink [xfs]: 240
> +xfs_symlink [xfs]: 256
Although, that one is a little unfortunate ;)
-eric
next prev parent reply other threads:[~2007-09-14 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 16:30 [PATCH 5/4] simplify xfs_create/mknod/symlink prototype Christoph Hellwig
2007-09-14 18:31 ` Eric Sandeen
2007-09-14 18:34 ` Eric Sandeen [this message]
2007-09-14 22:05 ` Christoph Hellwig
2007-09-15 3:27 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EAD432.1030704@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.