From: "Jan Beulich" <jbeulich@novell.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: "Andi Kleen" <ak@suse.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: constify stacktrace_ops
Date: Mon, 17 Sep 2007 09:58:39 +0100 [thread overview]
Message-ID: <46EE5DDF.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20070916031820.fc85d43d.akpm@linux-foundation.org>
>>> Andrew Morton <akpm@linux-foundation.org> 16.09.07 12:18 >>>
>On Mon, 10 Sep 2007 14:02:17 +0100 "Jan Beulich" <jbeulich@novell.com> wrote:
>
>> .. as they're never written to.
>
>arch/i386/kernel/traps.c: In function 'dump_trace':
>arch/i386/kernel/traps.c:197: warning: initialization discards qualifiers from pointer target type
>
>Due to
>
> struct ops_and_data oad = { .ops = ops, .data = data };
>
>messy to fix.
Not really - 'struct ops_and_data' can simply have its 'ops' member also be
declared 'struct stacktrace_ops *'. I actually have the patch this way here,
but since I generally submit patches against Linus' tree, I had to rip out
these hunks, since the structure gets added with the unwinder patch.
Jan
prev parent reply other threads:[~2007-09-17 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-10 13:02 [PATCH] x86: constify stacktrace_ops Jan Beulich
2007-09-16 10:18 ` Andrew Morton
2007-09-17 8:58 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EE5DDF.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.