From: Jeremy Fitzhardinge <jeremy@goop.org>
To: bbpetkov@yahoo.de
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] unify DMA_..BIT_MASK definitions
Date: Mon, 17 Sep 2007 11:48:54 -0700 [thread overview]
Message-ID: <46EECC16.10501@goop.org> (raw)
In-Reply-To: <20070917183346.GA9006@gollum.tnic>
Borislav Petkov wrote:
> That is more compact, I agree. However, the XXBIT_MASK macros have the
> better readability, imho. And also, doing
>
> $grep -Prin 'DMA_..BIT_MASK' * | wc -l
>
> returns 383 on the 23-rc6 tree so removing them should be quite the logistical
> challenge for the kernel janitors :). What do the others think?
>
Well, even defining the existing macros in terms of DMA_BIT_MASK would
be an improvement. It's certainly not obvious at first glance that
0x00000007ffffffffULL is a correct 35-bit mask - it's something that the
compiler is perfectly happy to compute for us.
J
prev parent reply other threads:[~2007-09-17 18:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 17:51 [PATCH 0/2] unify DMA_..BIT_MASK definitions Borislav Petkov
2007-09-17 18:14 ` Jeremy Fitzhardinge
2007-09-17 18:33 ` Borislav Petkov
2007-09-17 18:48 ` Jeremy Fitzhardinge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EECC16.10501@goop.org \
--to=jeremy@goop.org \
--cc=bbpetkov@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.