From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Lezcano Subject: Re: [net-2.6.24][patch 2/2] Dynamically allocate the loopback device Date: Mon, 17 Sep 2007 20:52:05 +0200 Message-ID: <46EECCD5.5090601@fr.ibm.com> References: <20070917134509.222896190@mai.toulouse-stg.fr.ibm.com> <20070917135133.466924283@mai.toulouse-stg.fr.ibm.com> <20070917101314.5d1673da@freepuppy.rosehill.hemminger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070917101314.5d1673da@freepuppy.rosehill.hemminger.net> Sender: netdev-owner@vger.kernel.org To: Stephen Hemminger Cc: dlezcano@fr.ibm.com, netdev@vger.kernel.org, "Eric W. Biederman" , containers@lists.osdl.org, davem@davemloft.net, Benjamin Thery List-Id: containers.vger.kernel.org Stephen Hemminger wrote: > On Mon, 17 Sep 2007 15:45:11 +0200 > dlezcano@fr.ibm.com wrote: > >> From: Daniel Lezcano >> >> Doing this makes loopback.c a better example of how to do a >> simple network device, and it removes the special case >> single static allocation of a struct net_device, hopefully >> making maintenance easier. >> > > What is before/after code and data size, does it make code smaller? Interesting question, here are the results based on the same config file. Without the patchset: ---------------------- vmlinux: text data bss dec hex filename 2446606 188243 163840 2798689 2ab461 vmlinux loopback.o text data bss dec hex filename 417 1040 8 1465 5b9 drivers/net/loopback.o With the patchset: ------------------ vmlinux: text data bss dec hex filename 2446853 187187 163840 2797880 2ab138 ./vmlinux loopback.o text data bss dec hex filename 609 4 12 625 271 drivers/net/loopback.o