From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Muli Ben-Yehuda <muli@il.ibm.com>
Cc: Borislav Petkov <bbpetkov@yahoo.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] unify DMA_..BIT_MASK definitions: v1
Date: Mon, 17 Sep 2007 23:01:21 -0700 [thread overview]
Message-ID: <46EF69B1.8020801@goop.org> (raw)
In-Reply-To: <20070918055803.GB4640@rhun.haifa.ibm.com>
Muli Ben-Yehuda wrote:
>> +#define DMA_64BIT_MASK DMA_BIT_MASK(64)
>>
>
> This one does not do what you mean. You need an explicit mask or a
> ~0ULL here.
Yeah, I was just about to comment on it. Its possible the compiler
might decide to shift by x%64 = 0.
J
next prev parent reply other threads:[~2007-09-18 6:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 4:29 [PATCH 0/2] unify DMA_..BIT_MASK definitions: v1 Borislav Petkov
2007-09-18 5:58 ` Muli Ben-Yehuda
2007-09-18 6:01 ` Jeremy Fitzhardinge [this message]
2007-09-18 6:08 ` Borislav Petkov
2007-09-18 6:16 ` Satyam Sharma
2007-09-18 6:34 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EF69B1.8020801@goop.org \
--to=jeremy@goop.org \
--cc=bbpetkov@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.