From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [PATCH 4/4] Account for the slub objects Date: Tue, 18 Sep 2007 10:28:26 +0400 Message-ID: <46EF700A.2080102@openvz.org> References: <46EE70B4.6060902@openvz.org> <46EE74AF.70105@openvz.org> <1190045368.26982.59.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1190045368.26982.59.camel@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Dave Hansen Cc: Linux Containers , Christoph Lameter List-Id: containers.vger.kernel.org Dave Hansen wrote: > On Mon, 2007-09-17 at 16:35 +0400, Pavel Emelyanov wrote: >> + >> + rcu_read_lock(); >> + cnt = task_kmem_container(current); >> + if (res_counter_charge(&cnt->res, s->size)) >> + goto err_locked; >> + >> + css_get(&cnt->css); >> + rcu_read_unlock(); >> + obj_container[slab_index(obj, s, page_address(pg))] = cnt; > > You made some effort in the description, but could we get some big fat > comments here about what RCU is doing? No big fat comment here - this all is containers API. > -- Dave > >