From: Rene Herman <rene.herman@gmail.com>
To: Krzysztof Helt <krzysztof.h1@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
ALSA devel <alsa-devel@alsa-project.org>,
Trent Piepho <xyzzy@speakeasy.org>
Subject: Re: Current ad1848/cs4231 mce_down code
Date: Tue, 18 Sep 2007 09:33:39 +0200 [thread overview]
Message-ID: <46EF7F53.5060208@gmail.com> (raw)
In-Reply-To: <20070918092821.773e522c.krzysztof.h1@gmail.com>
On 09/18/2007 09:28 AM, Krzysztof Helt wrote:
>> Moreover, we aren't under lock at all in the cs4231 version (which also
>> means that msleep(1) thing is in fact fine there). Can't we do that for
>> ad1848 as well?
>>
>
> The lock is right thing to do as Trent found out. The in() call writes
> to register. On the SMP setup it may backfire (cs4231 does not have
> locks but sparc cs4231 has them).
Yep, cs4231 is broken. Trent's new ad1848 version is the reference now it
seems. I'll fix up cs4231 if he doesn't beat me to it -- I'm still messing
with the Aztech cards so am testing cs4231 continously anyway...
Rene.
prev parent reply other threads:[~2007-09-18 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 0:53 Current ad1848/cs4231 mce_down code Rene Herman
2007-09-18 7:28 ` Krzysztof Helt
2007-09-18 7:33 ` Rene Herman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EF7F53.5060208@gmail.com \
--to=rene.herman@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=krzysztof.h1@gmail.com \
--cc=tiwai@suse.de \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.