From: Andreas Ericsson <ae@op5.se>
To: Ben Konrath <bkonrath@redhat.com>
Cc: git@vger.kernel.org
Subject: Re: [EGIT PATCH] Add feature and plugin.
Date: Tue, 18 Sep 2007 09:43:57 +0200 [thread overview]
Message-ID: <46EF81BD.7010609@op5.se> (raw)
In-Reply-To: <20070917185310.GA6042@toast.toronto.redhat.com>
Ben Konrath wrote:
> Hi,
>
> I made a feature and associated branding plugin for Egit. Including
> these two plugins allows us to build Egit for Fedora but it also makes
> it easy to create an update site for Egit.
> These two plugins also add an
> entry for Egit in Help -> About Eclipse -> Feature Details.
>
When you start writing "also" in your commit messages, it's a pretty good
sign that you should have made many smaller commits rathern than one large.
Aside from that, I don't know enough about eclipse, java or xml to be of
any assistance, although I appreciate the efforts put into this.
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2007-09-18 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 18:53 [EGIT PATCH] Add feature and plugin Ben Konrath
2007-09-18 7:43 ` Andreas Ericsson [this message]
2007-09-18 19:06 ` Robin Rosenberg
2007-09-18 21:20 ` Ben Konrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EF81BD.7010609@op5.se \
--to=ae@op5.se \
--cc=bkonrath@redhat.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.