All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rene Herman <rene.herman@gmail.com>
To: Nicolas Pitre <nico@cam.org>
Cc: Dmitry Torokhov <dtor_core@ameritech.net>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one
Date: Tue, 18 Sep 2007 16:53:30 +0200	[thread overview]
Message-ID: <46EFE66A.9090400@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

Hi Nicolas.

Given that it's not checking for signals, I believe this one should be an 
uninterruptible sleep instead?

Signed-off-by: Rene Herman <rene.herman@gmail.com>

Rene.

[-- Attachment #2: schedule_timeout-ucb1400_ts.diff --]
[-- Type: text/plain, Size: 530 bytes --]

diff --git a/drivers/input/touchscreen/ucb1400_ts.c b/drivers/input/touchscreen/ucb1400_ts.c
index f0cbcdb..670dd49 100644
--- a/drivers/input/touchscreen/ucb1400_ts.c
+++ b/drivers/input/touchscreen/ucb1400_ts.c
@@ -130,8 +130,7 @@ static unsigned int ucb1400_adc_read(struct ucb1400 *ucb, u16 adc_channel)
 		if (val & UCB_ADC_DAT_VALID)
 			break;
 		/* yield to other processes */
-		set_current_state(TASK_INTERRUPTIBLE);
-		schedule_timeout(1);
+		schedule_timeout_uninterruptible(1);
 	}
 
 	return UCB_ADC_DAT_VALUE(val);

             reply	other threads:[~2007-09-18 14:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-18 14:53 Rene Herman [this message]
2007-09-18 16:03 ` [PATCH] ucb1400_ts.c -- replace an interruptible sleep with an uninterruptible one Nicolas Pitre
2007-09-18 17:28   ` Rene Herman
2007-09-18 17:38     ` Nicolas Pitre
2007-09-18 19:11       ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46EFE66A.9090400@gmail.com \
    --to=rene.herman@gmail.com \
    --cc=dtor_core@ameritech.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.