Re: [PATCH] export man page updated.

[Chuck Lever <chuck.lever@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 2041 bytes --]

Steve Dickson wrote:
> Chuck Lever wrote:
>> Steve Dickson wrote:
>>> It was pointed that the exportfs man page talks about
>>> the wrong file. In 2.6 kernels the export information
>>> is now kept in /var/lib/nfs/etab not /var/lib/nfs/xtab.
>>>
>>> This patch basically does a 's/xtab/etab' and is relative
>>> to the to the Fedora git tree
>>>
>>> git://git.infradead.org/~steved/nfs-utils.fedora
>>
>> Hrm, an attachment.
> hmm... are you not seeing the attachments inlined?

When I reply the attachment is discarded so I have to do a number of 
steps to quote your patch that wouldn't be necessary if you had inlined 
the patch.  The point of inlining patches rather than attaching them is 
to allow others to quote the patch in their reply with no extra steps. 
And there are tools to import inlined patches -- not sure if they work 
for attachments.

It's a scalability thing when reviewers have to deal with dozens of 
patches a day.

>> @@ -93,8 +93,8 @@ file, so that only default options and options given 
>> on the command
>>  line are used.
>>  .TP
>>  .B -r
>> -Reexport all directories. It synchronizes /var/lib/nfs/xtab
>> -with /etc/exports. It removes entries in /var/lib/nfs/xtab
>> +Reexport all directories. It synchronizes /var/lib/nfs/etab
>> +with /etc/exports. It removes entries in /var/lib/nfs/etab
>>  which are deleted from /etc/exports, and remove any entries from the
>>  kernel export table which are no longer valid.
>>  .TP
>>
>> In this hunk, why isn't the file name bold, like the others?
> Thats the way it was. If its a problem, I'll respin the patch...

See http://www.faqs.org/docs/Linux-mini/Man-Page.html#Q8

"Filenames are always in italics."

I ask "why isn't this filename bold" because the other instances in this 
particular man page are also bold and not italicized...  which is 
marginally incorrect, if not unconventional.

It's hard to say something like this is "a problem" since it is only a 
man page.  But I like to leave things a little cleaner (more correct) 
than when I found them.

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 290 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
url:http://oss.oracle.com/~cel
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 228 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs