From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Chapman Subject: Re: [PATCH 2/3] [PPP] L2TP: Fix skb handling in pppol2tp_recv_core Date: Tue, 18 Sep 2007 21:17:12 +0100 Message-ID: <46F03248.80902@katalix.com> References: <20070918120438.GA9121@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Michal Ostrowski , Paul Mackerras , =?ISO-8859-1?Q?Toralf_F=F6rster?= , netdev@vger.kernel.org To: Herbert Xu Return-path: Received: from s36.avahost.net ([74.53.95.194]:50705 "EHLO s36.avahost.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbXIRURa (ORCPT ); Tue, 18 Sep 2007 16:17:30 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Herbert Xu wrote: > [PPP] L2TP: Fix skb handling in pppol2tp_recv_core > > The function pppol2tp_recv_core doesn't handle non-linear packets properly. > It also fails to check the remote offset field. > > This patch fixes these problems. It also removes an unnecessary check on > the UDP header which has already been performed by the UDP layer. > > Signed-off-by: Herbert Xu Acked-by: James Chapman -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development