From: Jeff Garzik <jeff@garzik.org>
To: David Miller <davem@davemloft.net>
Cc: shemminger@linux-foundation.org, netdev@vger.kernel.org,
Ariel.Hendel@sun.com, greg.onufer@sun.com
Subject: Re: [PATCH]: Preliminary release of Sun Neptune driver
Date: Wed, 19 Sep 2007 18:37:13 -0400 [thread overview]
Message-ID: <46F1A499.5060809@garzik.org> (raw)
In-Reply-To: <20070919.151144.59833230.davem@davemloft.net>
David Miller wrote:
> From: Jeff Garzik <jeff@garzik.org>
> Date: Wed, 19 Sep 2007 18:05:25 -0400
>
>> That said, the 2-arg macro arg order is wrong. It should be (reg,val)
>> like tg3 and other drivers.
>
> I actually wanted to mirror the ordering that
> writel() uses.
>
> So the choice is arbitrary, either be consistent with
> our well established asm/io.h interfaces or a bunch
> of network driver :-)
IMO (val,reg) was always unnatural. From looking at the register
read/write interfaces people continually reinvent, humans definitely
lean towards (reg,val).
Jeff
next prev parent reply other threads:[~2007-09-19 22:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 22:15 [PATCH]: Preliminary release of Sun Neptune driver David Miller
2007-09-19 21:59 ` Stephen Hemminger
2007-09-19 22:05 ` Jeff Garzik
2007-09-19 22:11 ` David Miller
2007-09-19 22:37 ` Jeff Garzik [this message]
2007-09-19 22:07 ` David Miller
2007-09-19 22:40 ` Jeff Garzik
2007-09-19 23:05 ` Stephen Hemminger
2007-09-19 23:17 ` David Miller
2007-09-19 23:20 ` Rick Jones
2007-09-19 23:53 ` David Miller
2007-09-20 16:06 ` Ariel Hendel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F1A499.5060809@garzik.org \
--to=jeff@garzik.org \
--cc=Ariel.Hendel@sun.com \
--cc=davem@davemloft.net \
--cc=greg.onufer@sun.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.