All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Dickgreber <tanzy@gmx.de>
To: linux-scsi@vger.kernel.org
Subject: [PATCH] qla1280: wasted space in allocated pages for request and response ring
Date: Thu, 20 Sep 2007 01:07:50 +0200	[thread overview]
Message-ID: <46F1ABC6.1020407@gmx.de> (raw)

Hi

i think there is wasted space in allocated pages for
request and response rings.
The allocations are made with REQUEST_ENTRY_CNT + 1 and
RESPONSE_ENTRY_CNT + 1, but they are set with 256 and 16.

So we got more pages, which we dont use very much.

Can you please check.

Signed-off-by: Johannes Dickgreber tanzy@gmx.de
---
--- qla1280.h.orig	2007-09-19 23:32:42 +0200
+++ qla1280.h	2007-09-19 23:44:37 +0200
@@ -91,8 +91,8 @@
 #define INVALID_HANDLE			(MAX_OUTSTANDING_COMMANDS + 2)

 /* ISP request and response entry counts (37-65535) */
-#define REQUEST_ENTRY_CNT		256 /* Number of request entries. */
-#define RESPONSE_ENTRY_CNT		16  /* Number of response entries. */
+#define REQUEST_ENTRY_CNT		255 /* Number of request entries. */
+#define RESPONSE_ENTRY_CNT		63  /* Number of response entries. */

 /*
  * SCSI Request Block structure  (sp)  that is placed


                 reply	other threads:[~2007-09-19 23:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46F1ABC6.1020407@gmx.de \
    --to=tanzy@gmx.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.