From: Johannes Dickgreber <tanzy@gmx.de>
To: linux-scsi@vger.kernel.org
Subject: [PATCH] qla1280: uses wrong failure path after failed pci_set_dma_mask
Date: Thu, 20 Sep 2007 01:07:57 +0200 [thread overview]
Message-ID: <46F1ABCD.8050102@gmx.de> (raw)
Hi
I think there will be a wrong goto target after a failed
pci_set_dma_mask.
Please Check.
Signed-off-by: Johannes Dickgreber tanzy@gmx.de
---
--- qla1280.c.orig 2007-09-19 23:32:33 +0200
+++ qla1280.c 2007-09-19 23:58:46 +0200
@@ -4298,7 +4298,7 @@ qla1280_probe_one(struct pci_dev *pdev,
printk(KERN_WARNING "scsi(%li): Unable to set a "
"suitable DMA mask - aborting\n", ha->host_no);
error = -ENODEV;
- goto error_free_irq;
+ goto error_put_host;
}
} else
dprintk(2, "scsi(%li): 64 Bit PCI Addressing Enabled\n",
@@ -4308,7 +4308,7 @@ qla1280_probe_one(struct pci_dev *pdev,
printk(KERN_WARNING "scsi(%li): Unable to set a "
"suitable DMA mask - aborting\n", ha->host_no);
error = -ENODEV;
- goto error_free_irq;
+ goto error_put_host;
}
#endif
reply other threads:[~2007-09-19 23:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F1ABCD.8050102@gmx.de \
--to=tanzy@gmx.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.