All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
To: Dmitry Adamushko <dmitry.adamushko@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched: fix to use invalid sched_class
Date: Wed, 19 Sep 2007 17:01:54 -0700	[thread overview]
Message-ID: <46F1B872.1050307@ct.jp.nec.com> (raw)
In-Reply-To: <1190239539.19576.5.camel@earth>

[-- Attachment #1: Type: text/plain, Size: 786 bytes --]

Dmitry Adamushko wrote:
>>> Hi Ingo,
>>>
>>> I found an issue about the scheduler.
>>> If you need a test case, please let me know.
>>> Here is a patch.
>>> [ ... ]
>>> The new thread should be valid scheduler class before queuing.
>>> This patch fixes to set the suitable scheduler class.
>> Nice fix! It's a 2.6.23 must-have fix - i'll push it out into the 
>> scheduler tree. Thanks!
> 
> I think, the following approach would be a bit more appropriate
> (the missing addition to the already existing "don't leak PI boosting prio"):
> 
> (not tested)
> 
Thank you for reviewing my patch.
Yes, your approach looks better than mine.
I've tested it and it looks working fine in my test case.
I attached the test case.

Will you write a patch to replace mine?

Thanks,
Hiroshi Shimamoto

[-- Attachment #2: mutexprio.c --]
[-- Type: image/x-xbitmap, Size: 882 bytes --]

  reply	other threads:[~2007-09-20  0:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-19 22:05 [PATCH] sched: fix to use invalid sched_class Dmitry Adamushko
2007-09-20  0:01 ` Hiroshi Shimamoto [this message]
2007-09-20  7:17   ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2007-09-19 21:14 Hiroshi Shimamoto
2007-09-19 21:37 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46F1B872.1050307@ct.jp.nec.com \
    --to=h-shimamoto@ct.jp.nec.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.adamushko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.