Re: [PATCH] move grp decoding to functions to make x86_emulate_insn() clearer

[Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>]

Avi Kivity wrote:
> Laurent Vivier wrote:
>> Avi Kivity wrote:
>>> Laurent Vivier wrote:
>>>> To improve readability, move push, writeback, and grp 1a/2/3/4/5 
>>>> emulation parts to functions.
>>>> +static inline int emulate_grp45(struct x86_emulate_ctxt *ctxt,
>>>> +                   struct x86_emulate_ops *ops,
>>>> +                   unsigned long *_eflags,
>>>> +                   int *no_wb)
>>>>   
>>>
>>> If you move _eflags and no_wb to the decode cache (in a separate 
>>> patch) then this patch can be much nicer.
>>
>> I agree but this increases the size of the structure shared with the 
>> userspace with variable used only locally in x86_emulate.c, is it 
>> acceptable ?
>>
> 
> It isn't shared with userspace, just part of the vcpu.

OK

> Looking a bit more, eflags is already present in x86_emulate_ctxt (and 

OK, I think we can do the same thing with cr2 ?

> could be moved from there), and no_wb can be merged into opcode_table 
> and twobyte_opcode_table, so long term there is no size change.

OK.

Laurent

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/