From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata-sff: Fix documentation
Date: Thu, 20 Sep 2007 15:59:20 -0400 [thread overview]
Message-ID: <46F2D118.4040609@garzik.org> (raw)
In-Reply-To: <20070920150307.6b89238b@the-village.bc.nu>
Alan Cox wrote:
> Code moved to ioread/iowrite but the comment didn't
> Also note a posting issue
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/libata-sff.c linux-2.6.23rc6-mm1/drivers/ata/libata-sff.c
> --- linux.vanilla-2.6.23rc6-mm1/drivers/ata/libata-sff.c 2007-09-18 15:32:51.000000000 +0100
> +++ linux-2.6.23rc6-mm1/drivers/ata/libata-sff.c 2007-09-18 16:18:05.000000000 +0100
> @@ -257,7 +261,7 @@
> dmactl = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_CMD);
> iowrite8(dmactl | ATA_DMA_START, ap->ioaddr.bmdma_addr + ATA_DMA_CMD);
>
> - /* Strictly, one may wish to issue a readb() here, to
> + /* Strictly, one may wish to issue an ioread8() here, to
> * flush the mmio write. However, control also passes
> * to the hardware at this point, and it will interrupt
> * us when we are to resume control. So, in effect,
> @@ -267,6 +271,9 @@
> * is expected, so I think it is best to not add a readb()
> * without first all the MMIO ATA cards/mobos.
> * Or maybe I'm just being paranoid.
> + *
> + * FIXME: The posting of this write means I/O starts are
> + * unneccessarily delayed for MMIO
applied
prev parent reply other threads:[~2007-09-20 19:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 14:03 [PATCH] libata-sff: Fix documentation Alan Cox
2007-09-20 19:59 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F2D118.4040609@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.